module.exports - Code Metrics - Inspection of "fix" - ericN93/module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1d44d5...cbfa7c )

by Eric

created 2017-12-08 09:14 UTC

module.exports A

↳ Parent: io.sockets.connection

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	4
c	3
b	0
f	0
nc	3
nop	1
dl	0
loc	9
rs	9.2

var io = require('socket.io').listen(5000);
var clients = {};

var verboseServer = false; //Good for debugging the server

verboseServer && console.log("ChatServer Started"); //If Verbose Debug

io.sockets.on('connection', function (socket) {
  verboseServer && console.log("New Connection"); //If Verbose Debug

  var userName;
  socket.on('connection name',function(user){
    verboseServer && console.log("Connection Name"); //If Verbose Debug

    userName = user.name;
    clients[user.name] = socket;
    io.sockets.emit('new user', user.name + " has joined.");
  });


  socket.on('message', function(msg){
    verboseServer && console.log("New msg"); //If Verbose Debug

    io.sockets.emit('message', msg);
  });

  socket.on('private message', function(msg){
    verboseServer && console.log("New PM"); //If Verbose Debug

    fromMsg = {from:userName, txt:msg.txt}

    clients[msg.to].emit('private message', fromMsg);
  });

  socket.on('disconnect', function(){
    verboseServer && console.log("disconnect"); //If Verbose Debug

    delete clients[userName];
  });
});


1			var io = require('socket.io').listen(5000);
2			var clients = {};
3
4			var verboseServer = false; //Good for debugging the server
5
6			verboseServer && console.log("ChatServer Started"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
7			io.sockets.on('connection', function (socket) {
8			verboseServer && console.log("New Connection"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
9			var userName;
10			socket.on('connection name',function(user){
11			verboseServer && console.log("Connection Name"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
12			userName = user.name;
13			clients[user.name] = socket;
14			io.sockets.emit('new user', user.name + " has joined.");
15			});
16
17
18			socket.on('message', function(msg){
19			verboseServer && console.log("New msg"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
20			io.sockets.emit('message', msg);
21			});
22
23			socket.on('private message', function(msg){
24			verboseServer && console.log("New PM"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
25			fromMsg = {from:userName, txt:msg.txt}
			0 ignored issues – show Bug introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The variable `fromMsg` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.fromMsg`. Loading history...
26			clients[msg.to].emit('private message', fromMsg);
27			});
28
29			socket.on('disconnect', function(){
30			verboseServer && console.log("disconnect"); //If Verbose Debug
			0 ignored issues – show Debugging Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
31			delete clients[userName];
32			});
33			});
34

ericN93 / module

Push — master ( 1d44d5...cbfa7c )

module.exports A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like